perf(market): serve cached image variants - #2024
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compact-v1(640 px) andlarge-v1(1280 px) image variants for MiniApp screenshots and Skin previewsVerification
cargo test -p bitfun-miniapp-market-service -p bitfun-skin-market-servicecargo check -p bitfun-miniapp-market-server -p bitfun-skin-market-serverpnpm run check:core-boundaries:test && pnpm run check:core-boundariespnpm run type-check:miniapp-market && pnpm run type-check:skin-market && pnpm run type-check:webpnpm run test:miniapp-market && pnpm run test:skin-marketpnpm --dir src/web-ui run test:run src/infrastructure/api/service-api/MarketImage.test.tspnpm run build:miniapp-market && pnpm run build:skin-marketProduction validation
Deployed exact commit
1253ab70c4390fca0d1fc1141bc778845e589b71to the isolated MiniApp and Skin market services after verifying daily backups and restore drills. Both containers are healthy and their public health endpoints pass. Sample compact payloads are approximately 74% smaller for MiniApp and 73% smaller for Skin.